Attached patch removes obsolete or mistaken code related to node translation:

* Mistaken handler that I started to draft in modules/translation, views_handler_field_node_tnid. Evidently this was misnamed (it was supposed to be a filter handler) and not completed. See #336125: error using "Node translation: Translation set node ID" filter.
* Two handlers leftover in modules/node that were moved to modules/translation.
* Two obsolete references to handlers in translation_views_handlers().

CommentFileSizeAuthor
#5 views-translation-cleanup.patch3.79 KBnedjo
#2 views-translation-cleanup.patch4.15 KBnedjo

Comments

merlinofchaos’s picture

merlinofchaos commented

There is no patch attached.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
StatusFileSize
new views-translation-cleanup.patch4.15 KB

Here's the patch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Hm, might be a conflict with one of your other patches now:

[merlin@furor views]$ patch -p0 < views-translation-cleanup.patch
patching file modules/translation.views.inc
Hunk #2 succeeded at 147 (offset 20 lines).
Hunk #3 FAILED at 154.
1 out of 3 hunks FAILED -- saving rejects to file modules/translation.views.inc.rej
patching file modules/node/views_handler_field_node_language.inc
patching file modules/node/views_handler_filter_node_language.inc
patching file modules/translation/views_handler_field_node_tnid.inc
nedjo’s picture

nedjo
he/him/his
Primary language English
commented

k, I'll reroll.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new views-translation-cleanup.patch3.79 KB

Rerolled.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Looks like this already went in at some point.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.